Remove use of python setup.py develop/install
#2716
Merged
+658
−421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_65 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
Collaborator
antonwolfy
force-pushed
the
do-not-use-setup-py-develop
branch
from
fa4542c to
6b9c18f
Compare
The change is based on implementation from dpctl#1692
Co-authored-by: vlad-perevezentsev <[email protected]>
…function when --c-compiler/--cxx-compiler passed to build scripts
antonwolfy
force-pushed
the
do-not-use-setup-py-develop
branch
from
311e43c to
8ceacaa
Compare
…_interfaces/--onemkl_interfaces_dir options
…rary) as required by oneMath repo
…lvm() build helper function
vlad-perevezentsev
approved these changes
Jan 19, 2026
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy !
github-actions bot
added a commit
that referenced
this pull request
Jan 19, 2026
A warning that `python setup.py develop` is deprecated and will no longer be supported at the end of October, 2025 has been ongoing for some time when using dpnp build driver scripts, and can be seen in the CI. The PR proposes instead relying on `pip` for installing dpnp in scripts, and reworks the scripts to maintain use of `scikit-build`. In the future, this will also simplify a transition to `scikit-build-core`. This PR also introduces options * `--clean` and `--skip-editable` to `build_locally` driver * `--clean` and `--skip-pytest` to `gen_coverage` driver Also it includes update of the documentation with new build instruction. 0ecd18e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning that
python setup.py developis deprecated and will no longer be supported at the end of October, 2025 has been ongoing for some time when using dpnp build driver scripts, and can be seen in the CI.The PR proposes instead relying on
pipfor installing dpnp in scripts, and reworks the scripts to maintain use ofscikit-build.In the future, this will also simplify a transition to
scikit-build-core.This PR also introduces options
--cleanand--skip-editabletobuild_locallydriver--cleanand--skip-pytesttogen_coveragedriverAlso it includes update of the documentation with new build instruction.